Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extending webpack plugin #3056

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Fix extending webpack plugin #3056

merged 2 commits into from
Apr 26, 2022

Conversation

DibyodyutiMondal
Copy link
Contributor

R: @jeffposnick @tropicadri

Fixes #3039

Made the config property of the webpack plugins protected.
This will allow child classes to access and modify the config property if necessary.

PS:
Ran into an issue while running the commands mentioned in contrbuting.md. The commands ran fine and modified a bunch of files (mostly package.jsons and content not modifieds), but when I tried to commit these extra changes, it gave me an error about husky. After that, the changes disappeared as well. I am not familiar with husky so I could not figure out what to do even after reading the docs. Re-running the commands did not make the changes come back either. So I made the changes on github.com in the browser itself and fetched the commits back. Given the nature of the changes I made, I assume that it does not really matter? Still worth mentioning, just in case.

@DibyodyutiMondal
Copy link
Contributor Author

@jeffposnick any update on this?

@jeffposnick jeffposnick self-requested a review April 26, 2022 16:11
@jeffposnick
Copy link
Contributor

Sorry for the delay, and thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make config property of InjectManifest class protected instead of private`
2 participants